Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • crown-core crown-core
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 75
    • Issues 75
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Crown
  • crown-corecrown-core
  • Issues
  • #118

Closed
Open
Created Feb 13, 2018 by Volodymyr Shamray@vshamrayReporter0 of 1 task completed0/1 task

Follow-up from "Gui bug fixes"

The following discussion from !85 (merged) should be addressed:

  • @vshamray started a discussion: (+1 comment)

    I appreciate extracting this method from processNewTransaction, I think it was definitely a right thing to do. However, having said that, this function contains several responsibilities, which usually belong not just to different functions or classes, but to different architectural layers:

    1. Showing dialogs / formatting strings - UI layer
    2. Manipulating configs - Infrastructure layer
    3. Manipulating objects from domain layer, setting port numbers - Application layer

    We should consider refactoring this function towards better separation of concerns.

    (layers are given as described, for example, here: http://wiki.c2.com/?FourLayerArchitecture)

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking