GitLab

Summary

debug.log contains multiple block creation failures.

Steps to reproduce

No specific steps

Expected behavior

invalid blocks should not be created and debug.log shouldn't be full of scary looking error messages

Problematic behavior

Lots of invalid blocks are generated. A single masternode has recorded hundreds of occurrences over the last 4.5 days:

mark@x230:~/tmp$ grep -c CMasternodePayments::IsTransactionValid 2019*morra*
20190120_walkjivefly_MN_morra1.log:120
20190121_walkjivefly_MN_morra1.log:1114
20190122_walkjivefly_MN_morra1.log:662
20190123_walkjivefly_MN_morra1.log:487
20190124_walkjivefly_MN_morra1.log:148

Crown-core environment info

Ubuntu 16.04

Crown-core application info

Crown version v0.12.7.1-2029222a

Relevant logs, dumps and/or screenshots

2019-01-21 03:16:17 CreateCoinStake: Found valid kernel for mn/sn collateral COutPoint(efbfe1ce31dbd992f06ed997e1091794d048c11f2d871126be8752ac49964aa4, 1)
2019-01-21 03:16:17 CreateCoinStake: OutPoint: 456ed98aa8e8eba3982a028ede80f3b353288e2f0d1576cbcebdb4b3cb912287:1 Modifier=c5d49b4e84e963540af82d476116e6fddd75d4de56280389ee87b1c911c81ad4 timeblockfrom=1548019332 time=1548040607 amount=10000
2019-01-21 03:16:17 Masternode payment to tCRWVWYozEJrVobYG95M26jj8HzQ2nAcZyk6G
2019-01-21 03:16:17 Systemnode payment to tCRWDkTtv9HURr1xNV5HQpGJqSQ7Ji9gFmYeM
2019-01-21 03:16:17 CreateNewBlock(): total size 13170
2019-01-21 03:16:17 CMasternodePayments::IsTransactionValid - Missing required payment of 6.00 to tCRWVWYozEJrVobYG95M26jj8HzQ2nAcZyk6G
2019-01-21 03:16:17 Invalid mn payment detected CTransaction(hash=9aef24b71f, ver=1, vin.size=1, vout.size=3, nLockTime=0)
    CTxIn(COutPoint(0000000000000000000000000000000000000000000000000000000000000000, 4294967295), coinbase 02624c00)
    CTxOut(nValue=0.00000000, scriptPubKey=)
    CTxOut(nValue=6.00118920, scriptPubKey=OP_DUP OP_HASH160 b53695d9306c)
    CTxOut(nValue=1.20023784, scriptPubKey=OP_DUP OP_HASH160 08564b1e177c)

2019-01-21 03:16:17 ERROR: CheckBlock() : Couldn't find masternode/budget payment
2019-01-21 03:16:17 CreateNewBlock() : TestBlockValidity failed
  CBlock(hash=37a65da7efc93587a87ac7026f8ebe6be06de11f29c2c25f63689602c069b862, ver=1442306, hashPrevBlock=00eec419cd592d2a484ef3aea8f3ada054f820e981e32a9d1bb0fb7b60412dc4, hashMerkleRoot=8080aa1c987983c4273874c7635c6133f981e9ad058bddf46f7d80529cd27475, nTime=1548040607, nBits=1d0a4338, nNonce=0, vtx=3)
  CTransaction(hash=9aef24b71f, ver=1, vin.size=1, vout.size=3, nLockTime=0)
    CTxIn(COutPoint(0000000000000000000000000000000000000000000000000000000000000000, 4294967295), coinbase 02624c00)
    CTxOut(nValue=0.00000000, scriptPubKey=)
    CTxOut(nValue=6.00118920, scriptPubKey=OP_DUP OP_HASH160 b53695d9306c)
    CTxOut(nValue=1.20023784, scriptPubKey=OP_DUP OP_HASH160 08564b1e177c)

  CTransaction(hash=1da1a63fc7, ver=1, vin.size=1, vout.size=1, nLockTime=0)
    CTxIn(COutPoint(0000000000000000000000000000000000000000000000000000000000000000, 4294967295), coinbase c002624c00)
    CTxOut(nValue=4.79857296, scriptPubKey=OP_DUP OP_HASH160 c28b65bdef31)

  CTransaction(hash=4b3bc9738f, ver=1, vin.size=82, vout.size=2, nLockTime=0)
    CTxIn(COutPoint(4489e557fbd7d02bf21105fc2c2209de0f4a8db1bc0ddbfc9b2fb76543630139, 1), scriptSig=304402201b8db83171964270)
    CTxIn(COutPoint(384d14c374a4405b3012bb15433ae72a06566c8879a9e48f9f8d4b60988a6627, 1), scriptSig=304402207f8a9897ba7b82ed)
    CTxIn(COutPoint(0f1937120864e9eba76ef4f88d9d17cbb51a7c883ed31e1f1acc67624616198f, 1), scriptSig=3044022073f617afbfb0cc1a)
    CTxIn(COutPoint(3476b121f333231b470f56f05081d071d01bda7b4e4d0550a2a86db24d59ee2a, 1), scriptSig=3045022100a444509abfe9f3)
...
    CTxIn(COutPoint(6ebd1d83142440b0007c159bc79655c5c23d62670ad435342a068e9e5b3507f5, 1), scriptSig=3044022048e96fbd6b90f48b)
    CTxOut(nValue=5000.00000000, scriptPubKey=OP_DUP OP_HASH160 4f04a277c490)
    CTxOut(nValue=0.01072965, scriptPubKey=OP_DUP OP_HASH160 6e73128f60e5)

  vMerkleTree:  9aef24b71f458b9c181e646325ecb0f33d375e8733b463ba34219526bf2a60fd 1da1a63fc70f3d8202b0abb6c6f64da922b946c42d47fb61f818616fce9ed0c5 4b3bc9738f728b23c21438d636fd811ceeb139c7d7b56c693b6e2d1c374c5ce1 987ad1f420891f57a38842eb3fac16ac8142f9668353c2f410aa7b839211dfe7 5c7ad70b024d19945c5fb5e99a68c3d9ed2b0424796f23edada3ab623b7d8de2 8080aa1c987983c4273874c7635c6133f981e9ad058bddf46f7d80529cd27475

2019-01-21 03:16:17 ResendWalletTransactions()

Uploaded 20190120_walkjivefly_MN_morra1.log to https://nextcloud.crown.tech/nextcloud/s/znd8HiiAsRX3C6B

Possible fixes

(Any comments on what you think might be responsible for the problem, if you have particular insight.)

/cc @artem