Skip to content

GitLab

Closed
Created by Mark Brooker@walkjiveflyMaintainer

PoS testing: incorrect superblock payments stall the chain

Summary

Superblock 32550 stalled the chain by crashing all the stake-miner threads.

Steps to reproduce

Submit a proposal which passes.

Expected behavior

Passing proposals should be paid the correct amounts and the chain continue as normal.

Problematic behavior

Superblock tried to pay invalid amounts (eg: 2 billion instead of 20) which crashes the stake-miner thread. Same thing happens for every other node which attempts to mine the superblock and the chain stalls.

Crown-core environment info

Ubuntu 16.04

Crown-core application info

Crown version v0.12.7.3-2f1de615

Relevant logs, dumps and/or screenshots

2019-02-04 15:55:40 CreateCoinStake: Found valid kernel for mn/sn collateral COutPoint(efbfe1ce31dbd992f06ed997e1091794d048c11f2d871126be8752ac49964aa4, 1)
2019-02-04 15:55:40 CreateCoinStake: OutPoint: 01d1b71070c37240bb89da0b890d2c458fbbfb3b36622215d50001152a816529:1 Modifier=ba576fda7895f243a40e6b0e3020dda4871f5e19560f6b82057fe6bff43ff58d timeblockfrom=1549199012 time=1549295771 amount=10000
2019-02-04 15:55:40 CBudgetManager::FillBlockPayee - Budget payment to tCRWVKAu5BJ6b2GbTXQCF5JKWwYpDHaM3xVwn for 2000000000; proposal 2911dbd5d9c90e196fc33d3a823d4465aa6d5cf0f4f41b32ac680a452684e216
2019-02-04 15:55:40 CBudgetManager::FillBlockPayee - Budget payment to tCRWVKAu5BJ6b2GbTXQCF5JKWwYpDHaM3xVwn for 2000000000; proposal f107313e1dd8f448663b17621047706a78f5e11627df5d0c78ef384428f4707c
2019-02-04 15:55:40 CBudgetManager::FillBlockPayee - Budget payment to tCRWNx1f2CVwox8dJXwjFjS9NRxhqqmP6gfWT for 1337000000; proposal 14f2bfc9c6d96725ed29271dd8d120915e6f854a015cbc827b192b8fa6667049
2019-02-04 15:55:40 CreateNewBlock(): total size 1372
2019-02-04 15:55:40 CrownMiner runtime error: CTransaction::GetValueOut() : value out of range
2019-02-04 15:55:40 keypool return 1647
2019-02-04 15:55:40 ThreadStakeMinter exiting,
2019-02-04 15:55:40 stake-miner thread exit

Uploaded 20190204_walkjivefly_MN_morra1_superblock_failure.log to https://nextcloud.crown.tech/nextcloud/s/znd8HiiAsRX3C6B

Possible fixes

Budgets are using wrong units? satoshis vs tCRW (eg: 2 billion satoshis vs 20 tCRW)

/cc @artem

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information