Consistency/fencepost error in CSystemnode::GetRecentPaymentBlocks
Summary
Code inconsistency
Steps to reproduce
Compare the code in CSystemnode::GetRecentPaymentBlocks and CMasternode::GetRecentPaymentBlocks. There is a discrepancy between (MN)
int nMinimumValidBlockHeight = chainActive.Height() - Params().ValidStakePointerDuration() + 1;and (SN)
int nMinimumValidBlockHeight = chainActive.Height() - Params().ValidStakePointerDuration();Expected behavior
The assignment should be the same in both cases.
Problematic behavior
Minor inconsistency between MNs and SNs.
Crown-core environment info
N/A
Crown-core application info
Crown version v0.13.4.0-bf750d36
Relevant logs, dumps and/or screenshots
N/A
Possible fixes
Change the SN code to match the MN code.
/cc @artem
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information