Incorrect budget floating around for superblock 2462400
Summary
The active proposals list for superblock 2462400 contains several "expired" proposals. By expired I mean they are proposals for superblock 2376000 (2 superblocks ago) which asked for a single payment. However, the RemainingPaymentCount is incorrect (=1) and mnbudget check doesn't remove them from the list.
Interestingly, it is possible to vote on these expired proposals but fortunately those with a high enough net Yes score to pass are not considered passing by mnbudget projection.
So probably no harm will be done beyond sowing confusion.
Steps to reproduce
Don't know how it happened but the results can be seen at the Proposals page on CrownCentral.net. These expired proposals didn't show up there last month so I guess the proposal set being passed around came from a node which was offline for a while and then came back online recently.
Expected behavior
Expired proposals should stay expired.
Problematic behavior
There are proposals in the system with RemainingPaymentCount=1 when it should be 0. It is possible to vote for these proposals from the command line. People who rely on CrownCentral for information about active proposals could be confused and vote on an incorrect proposal set.
These expired proposals are not visible in the QT wallet so people voting from there will be less affected.
Crown-core environment info
MX 17.1 Linux
Crown-core application info
v0.13.4
Relevant logs, dumps and/or screenshots
These are the problem proposals:
crown-cli mnbudget show output:
mark@x230:~$ crown-cli mnbudget show
{
"Electrum-MNPOS" : {
"Name" : "Electrum-MNPOS",
"URL" : "https://bit.ly/2ILADkc",
"Hash" : "6c0bfedef0785d8d8394392c3f7b02313a7d3feb9fb3de8d2b7d852b99405104",
"FeeHash" : "02fbcc8a205bc4c1a2163f1cc9d95a7b2ec46e2be30924f365bd842af962bf19",
"BlockStart" : 2376000,
"BlockEnd" : 2484000,
"TotalPaymentCount" : 2,
"RemainingPaymentCount" : 0,
"PaymentAddress" : "CRWNKVaPrpz8bgEH9dzymiC2aTwj6duga9UN",
"Ratio" : 0.99000000,
"Yeas" : 188,
"Nays" : 2,
"Abstains" : 0,
"TotalPayment" : 10000.00000000,
"MonthlyPayment" : 5000.00000000,
"IsEstablished" : 1,
"IsValid" : true,
"IsValidReason" : "",
"fValid" : true
},
"conf-sponsor-spain" : {
"Name" : "conf-sponsor-spain",
"URL" : "https://bit.ly/2JPOzcY",
"Hash" : "7f7a06147f6ad55962fe7ad59728e7292d9d66315fa21b13d4e561757ab10c05",
"FeeHash" : "6a6de2e90c4c1151defb90107e73ae1e0f831d58567b59c8d51980bee8001c2f",
"BlockStart" : 2419200,
"BlockEnd" : 2484000,
"TotalPaymentCount" : 1,
"RemainingPaymentCount" : 0,
"PaymentAddress" : "CRWUg2DdyaRY4DCDTQPncpfnAjbtt5LG9m7Y",
"Ratio" : 0.96624473,
"Yeas" : 210,
"Nays" : 8,
"Abstains" : 0,
"TotalPayment" : 4000.00000000,
"MonthlyPayment" : 4000.00000000,
"IsEstablished" : 1,
"IsValid" : true,
"IsValidReason" : "",
"fValid" : true
},
"webdevMay" : {
"Name" : "webdevMay",
"URL" : "https://forum.crown.tech/index.php?topic=36959.0",
"Hash" : "4be490bacfae4bf7bf09a3b291642619a87c1fb633a8babcfdfee2fed9579f21",
"FeeHash" : "f740b1072c948b70615a8a1ce1d550cbe4380402c92aabce0e9a3ad8f45e375e",
"BlockStart" : 2419200,
"BlockEnd" : 2484000,
"TotalPaymentCount" : 1,
"RemainingPaymentCount" : 0,
"PaymentAddress" : "CRWPV5HUUH3BisNwFEmkBh1H7kQSzmP4y8AR",
"Ratio" : 0.95580110,
"Yeas" : 166,
"Nays" : 8,
"Abstains" : 0,
"TotalPayment" : 2000.00000000,
"MonthlyPayment" : 2000.00000000,
"IsEstablished" : 1,
"IsValid" : true,
"IsValidReason" : "",
"fValid" : true
},
"CommunityActivationP" : {
"Name" : "CommunityActivationP",
"URL" : "http://bit.ly/30Rvey7",
"Hash" : "3b499bc980b7abc0174dc473e045704ba9320c09578e29c82eea0e32606eb421",
"FeeHash" : "d769034596f3e76d7ad8bc19f9da000e70b3f02d31fd4db96f9cdf1f004031b1",
"BlockStart" : 2419200,
"BlockEnd" : 2484000,
"TotalPaymentCount" : 1,
"RemainingPaymentCount" : 0,
"PaymentAddress" : "CRWRnqKWZMdeLjHcXp5vGmHqyk1wf4D3zS97",
"Ratio" : 0.93137255,
"Yeas" : 89,
"Nays" : 7,
"Abstains" : 0,
"TotalPayment" : 2251.00000000,
"MonthlyPayment" : 2251.00000000,
"IsEstablished" : 1,
"IsValid" : true,
"IsValidReason" : "",
"fValid" : true
},
"ashot-dev-april" : {
"Name" : "ashot-dev-april",
"URL" : "http://bit.ly/2H6DmD7",
"Hash" : "58dd80cebdaa28979621c8b831e67747ea1e0ef43d392a1957259a09c7d1d725",
"FeeHash" : "fb843cf9a27bf2c940cfc77a95230eb468ad9fc5a62d7f8b7e251d872c63ab9e",
"BlockStart" : 2376000,
"BlockEnd" : 2440800,
"TotalPaymentCount" : 1,
"RemainingPaymentCount" : 1,
"PaymentAddress" : "CRWH4nR8c28ZArKg7cL2XJ5dcKzTDPoTfDbM",
"Ratio" : 0.99339934,
"Yeas" : 298,
"Nays" : 2,
"Abstains" : 0,
"TotalPayment" : 16000.00000000,
"MonthlyPayment" : 16000.00000000,
"IsEstablished" : 1,
"IsValid" : true,
"IsValidReason" : "",
"fValid" : true
},
"CommunityActivationP" : {
"Name" : "CommunityActivationP",
"URL" : "http://bit.ly/30Rvey7",
"Hash" : "10be76c6ff858ad6b6e452554e515f1054190d5979c31e46d010b28710c94c28",
"FeeHash" : "cb7b5ba7fb50ddeaafd25764ade78f0657eb5afb88ca151e2700b4c91b126e25",
"BlockStart" : 2462400,
"BlockEnd" : 2527200,
"TotalPaymentCount" : 1,
"RemainingPaymentCount" : 1,
"PaymentAddress" : "CRWXwFJZ9a41bARqRQof2cSsdDHrCpqqMeuU",
"Ratio" : 0.00000000,
"Yeas" : 0,
"Nays" : 10,
"Abstains" : 0,
"TotalPayment" : 2346.00000000,
"MonthlyPayment" : 2346.00000000,
"IsEstablished" : 1,
"IsValid" : true,
"IsValidReason" : "",
"fValid" : true
},
"JOATMON-2019104" : {
"Name" : "JOATMON-2019104",
"URL" : "https://bit.ly/2VhZ5j1",
"Hash" : "4deeb6767a6d28bc46610368744aeefb17ff2aa6a79eee6b1f67fdfb63f5dd48",
"FeeHash" : "b78e180abf215d8ca1000be572d61f6c49863c369a5e317cb709f11a33b8002c",
"BlockStart" : 2376000,
"BlockEnd" : 2440800,
"TotalPaymentCount" : 1,
"RemainingPaymentCount" : 1,
"PaymentAddress" : "CRWR9XsDEAoeF9i5G1DZTjirroczY17eo5ZM",
"Ratio" : 1.00000000,
"Yeas" : 286,
"Nays" : 0,
"Abstains" : 0,
"TotalPayment" : 2000.00000000,
"MonthlyPayment" : 2000.00000000,
"IsEstablished" : 1,
"IsValid" : true,
"IsValidReason" : "",
"fValid" : true
},
"design-service-may19" : {
"Name" : "design-service-may19",
"URL" : "https://bit.ly/2UC0MUh",
"Hash" : "fba0331f2b6809455365c069fe164b038cc6e94b46ddf050ce3e5abc245ab64e",
"FeeHash" : "11843ad388e9acff6ba82f2c96a31ba12ab6be9cafe8945f91819b0cfeba7a74",
"BlockStart" : 2376000,
"BlockEnd" : 2440800,
"TotalPaymentCount" : 1,
"RemainingPaymentCount" : 1,
"PaymentAddress" : "CRWMwDUpqPWWXM8jov9fAgy34kdsXK994WX8",
"Ratio" : 1.00000000,
"Yeas" : 131,
"Nays" : 0,
"Abstains" : 0,
"TotalPayment" : 3000.00000000,
"MonthlyPayment" : 3000.00000000,
"IsEstablished" : 1,
"IsValid" : true,
"IsValidReason" : "",
"fValid" : true
},
"JOATMON-201905" : {
"Name" : "JOATMON-201905",
"URL" : "https://forum.crown.tech/index.php?topic=36956.0",
"Hash" : "3c67369ab31786ab1bff83c3634a71eb3b9b8983260d1f97c0e664bc741cdb4f",
"FeeHash" : "c0202db95901a9f359d9ae916cfdac4fba48708baa774b49607dd71ea719ae7e",
"BlockStart" : 2419200,
"BlockEnd" : 2484000,
"TotalPaymentCount" : 1,
"RemainingPaymentCount" : 0,
"PaymentAddress" : "CRWWnUyXqb9tjc2g5HnMSPtuWcaZKHbbzjzJ",
"Ratio" : 0.99090909,
"Yeas" : 202,
"Nays" : 2,
"Abstains" : 0,
"TotalPayment" : 2000.00000000,
"MonthlyPayment" : 2000.00000000,
"IsEstablished" : 1,
"IsValid" : true,
"IsValidReason" : "",
"fValid" : true
},
"april-webdev-tasks" : {
"Name" : "april-webdev-tasks",
"URL" : "https://forum.crown.tech/index.php?topic=36953.0",
"Hash" : "875ae85cf16b3426c885e6cd441fddf407c127761e993cf4b58248cd94752353",
"FeeHash" : "217bb202e542d8cc5c2856892478b5d5dc7255ffc778288a92f25afdb8732df6",
"BlockStart" : 2376000,
"BlockEnd" : 2440800,
"TotalPaymentCount" : 1,
"RemainingPaymentCount" : 1,
"PaymentAddress" : "CRWSLvTmH7CPcNbvrcS8NkSr95Z1Z7gjq2Jq",
"Ratio" : 1.00000000,
"Yeas" : 103,
"Nays" : 0,
"Abstains" : 0,
"TotalPayment" : 4125.00000000,
"MonthlyPayment" : 4125.00000000,
"IsEstablished" : 1,
"IsValid" : true,
"IsValidReason" : "",
"fValid" : true
},
"ashot-dev-may" : {
"Name" : "ashot-dev-may",
"URL" : "http://bit.ly/2HBxpye",
"Hash" : "d33bf4f9e5c772b7ab18a990a04258bec2c373362f25da2a97b6d9fbb1275b86",
"FeeHash" : "dac2a8150d5d202dd1a452579c57ed59e73968baabf966f6fbeda2feb75b9754",
"BlockStart" : 2419200,
"BlockEnd" : 2484000,
"TotalPaymentCount" : 1,
"RemainingPaymentCount" : 0,
"PaymentAddress" : "CRWSQjAJtwT155BvfVrYtJafiySWefj19TLk",
"Ratio" : 0.99734043,
"Yeas" : 367,
"Nays" : 1,
"Abstains" : 0,
"TotalPayment" : 16000.00000000,
"MonthlyPayment" : 16000.00000000,
"IsEstablished" : 1,
"IsValid" : true,
"IsValidReason" : "",
"fValid" : true
},
"JOATMON-201906" : {
"Name" : "JOATMON-201906",
"URL" : "https://forum.crown.tech/index.php?topic=36961.0",
"Hash" : "125a3aa6f0a563ae1c90f6ac952cd3d0d19f0974864b2eefcd1d69e222d41990",
"FeeHash" : "38f591193f9a2ca728e0134e3530322cf407380e78164cc0ee0dd93b95867867",
"BlockStart" : 2462400,
"BlockEnd" : 2527200,
"TotalPaymentCount" : 1,
"RemainingPaymentCount" : 1,
"PaymentAddress" : "CRWNg4zvUi4N5QV43GgSYnbVypskwb8hpVyg",
"Ratio" : 0.93750000,
"Yeas" : 24,
"Nays" : 2,
"Abstains" : 0,
"TotalPayment" : 2000.00000000,
"MonthlyPayment" : 2000.00000000,
"IsEstablished" : 1,
"IsValid" : true,
"IsValidReason" : "",
"fValid" : true
},
"Bitcore-MNPOS" : {
"Name" : "Bitcore-MNPOS",
"URL" : "https://bit.ly/2vdpPT8",
"Hash" : "49819978f6c302e53d0ba037d991d231bc32ac1daac36496a6dba2f3d1d25f92",
"FeeHash" : "e025440575f4b0336fc84940db0a2f8a9684288c8f9eb2fa4d7332ee5472363a",
"BlockStart" : 2376000,
"BlockEnd" : 2484000,
"TotalPaymentCount" : 2,
"RemainingPaymentCount" : 0,
"PaymentAddress" : "CRWQHLjFBDmvckf8zPEC9dpVkPsCeANiPKsa",
"Ratio" : 0.99029126,
"Yeas" : 192,
"Nays" : 2,
"Abstains" : 0,
"TotalPayment" : 10000.00000000,
"MonthlyPayment" : 5000.00000000,
"IsEstablished" : 1,
"IsValid" : true,
"IsValidReason" : "",
"fValid" : true
},
"artem-dev-may" : {
"Name" : "artem-dev-may",
"URL" : "https://bit.ly/2JkHQrd",
"Hash" : "34dafb5264baec914501f9db1339e08ce1c5da23d734e5e6f2fc77dcf9a38db5",
"FeeHash" : "06497d1b5783de7e5191302bd527efeaf3176628af3d4b5b248df5ad5d27ea4a",
"BlockStart" : 2419200,
"BlockEnd" : 2484000,
"TotalPaymentCount" : 1,
"RemainingPaymentCount" : 0,
"PaymentAddress" : "CRWLAZSR4uRvYjN1jwBczUFofvgvQyFacY8B",
"Ratio" : 0.99723757,
"Yeas" : 340,
"Nays" : 1,
"Abstains" : 0,
"TotalPayment" : 20000.00000000,
"MonthlyPayment" : 20000.00000000,
"IsEstablished" : 1,
"IsValid" : true,
"IsValidReason" : "",
"fValid" : true
},
"infra-2019-junjul" : {
"Name" : "infra-2019-junjul",
"URL" : "http://bit.ly/CrownInfraJunJul19",
"Hash" : "6186cd606e6568a1c4f6aefe4ee180b3e95ade5585e6cae17f8b95f0158fc5c3",
"FeeHash" : "c1c9abb9bf641dec99fda5b9ece6d303936b77f64e1055ff6bf2e259c97fadb0",
"BlockStart" : 2419200,
"BlockEnd" : 2527200,
"TotalPaymentCount" : 2,
"RemainingPaymentCount" : 1,
"PaymentAddress" : "CRWSLkd5kdm2rifYVbNbpeWwzPXwncJo3ynS",
"Ratio" : 0.99354839,
"Yeas" : 148,
"Nays" : 1,
"Abstains" : 0,
"TotalPayment" : 12932.00000000,
"MonthlyPayment" : 6466.00000000,
"IsEstablished" : 1,
"IsValid" : true,
"IsValidReason" : "",
"fValid" : true
},
"artem-dev-april" : {
"Name" : "artem-dev-april",
"URL" : "https://bit.ly/2JkHQrd",
"Hash" : "41ccc824f5aac070c39b4858d02632e250286e9ab681e18f017a12ff9bad30f7",
"FeeHash" : "d8d9c8977c4d9baf240917a6706dd3e0633ffa5299764908356f75c5f92ffac5",
"BlockStart" : 2376000,
"BlockEnd" : 2440800,
"TotalPaymentCount" : 1,
"RemainingPaymentCount" : 1,
"PaymentAddress" : "CRWU5eDVx1LbRW9o5YtopDYdxBAYpfVfNTsE",
"Ratio" : 1.00000000,
"Yeas" : 103,
"Nays" : 0,
"Abstains" : 0,
"TotalPayment" : 17900.00000000,
"MonthlyPayment" : 17900.00000000,
"IsEstablished" : 1,
"IsValid" : true,
"IsValidReason" : "",
"fValid" : true
}
}Graphical representation of the crown-cli mnbudget show output
and the way it looks in the QT wallet
Drop full logs & dumps here: https://nextcloud.crown.tech/nextcloud/s/znd8HiiAsRX3C6B
Possible fixes
Maybe they'll drop off the list in about one week at block 2440800.
/cc @artem
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information