GitLab

Summary

QA: nftproto register does not validate the new tokenProtocolId according to the rules given in the help

Steps to reproduce

mark@x230:~/.crowntest/testnet3$ tcrowncli nftproto register 01 "Test 01" tCRWPpEZVu93MVGYS9FqEjV9XAW9sgKz3MMTp 
e62013a19769da65c519c2685c3c487ec415c05f0108b04124a589432d944df6

Expected behavior

Should be rejected because it's too short and contains an invalid character

Problematic behavior

Protocol is created with id ".1"

mark@x230:~/.crowntest/testnet3$ tcrowncli nftproto getbytxid e62013a19769da65c519c2685c3c487ec415c05f0108b04124a589432d944df6
{
    "blockHash" : "c558bcf41ea384a0ffc7f27a4ecde59d57cee7202143ae2b7fa540172b153fc5",
    "registrationTxHash" : "e62013a19769da65c519c2685c3c487ec415c05f0108b04124a589432d944df6",
    "height" : 351827,
    "timestamp" : 1581604525,
    "nftProtocolId" : ".1",
    "tokenProtocolName" : "Test 01",
    "tokenMetadataSchemaUri" : "",
    "tokenMetadataMimeType" : "text/plain",
    "isTokenTransferable" : true,
    "isMetadataEmbedded" : false,
    "nftRegSign" : "SignByCreator",
    "maxMetadataSize" : 255,
    "tokenProtocolOwnerId" : "tCRWPpEZVu93MVGYS9FqEjV9XAW9sgKz3MMTp"
}

Crown-core environment info

Ubuntu 16.04

Crown-core application info

v0.13.9.3 build 1166

Relevant logs, dumps and/or screenshots

(Paste any relevant logs - please use code blocks (```) to format console output, logs, and code; it's very hard to read otherwise.)

Drop full logs & dumps here: https://nextcloud.crownplatform.com/index.php/s/Q6H8enXNmJsQYCD

Possible fixes

(Any comments on what you think might be responsible for the problem, if you have particular insight.)

/cc @artem