GitLab

Summary

QA: nftproto register does not validate the new tokenProtocolId according to the rules given in the help

Steps to reproduce

mark@x230:~/.crowntest/testnet3$ tcrowncli nftproto register 006 "Test 01" tCRWPpEZVu93MVGYS9FqEjV9XAW9sgKz3MMTp 
033d785172f875ce61ccf4839c64f9af0b6384a85f5688acf7cd68516bdf357a

Expected behavior

Should be rejected, all characters are invalid

Problematic behavior

mark@x230:~/.crowntest/testnet3$ tcrowncli nftproto getbytxid 033d785172f875ce61ccf4839c64f9af0b6384a85f5688acf7cd68516bdf357a
{
    "blockHash" : "6a09f61d968644e38149df37d715ed37f6878070dfb98bafdbeec6b6cf215231",
    "registrationTxHash" : "033d785172f875ce61ccf4839c64f9af0b6384a85f5688acf7cd68516bdf357a",
    "height" : 351811,
    "timestamp" : 1581603205,
    "nftProtocolId" : ".............",
    "tokenProtocolName" : "Test 01",
    "tokenMetadataSchemaUri" : "",
    "tokenMetadataMimeType" : "text/plain",
    "isTokenTransferable" : true,
    "isMetadataEmbedded" : false,
    "nftRegSign" : "SignByCreator",
    "maxMetadataSize" : 255,
    "tokenProtocolOwnerId" : "tCRWPpEZVu93MVGYS9FqEjV9XAW9sgKz3MMTp"
}

Protocol is created and the Id is longer than allowed.

Crown-core environment info

Ubuntu 16.04

Crown-core application info

v0.13.9.3 build 1166

Relevant logs, dumps and/or screenshots

(Paste any relevant logs - please use code blocks (```) to format console output, logs, and code; it's very hard to read otherwise.)

Drop full logs & dumps here: https://nextcloud.crownplatform.com/index.php/s/Q6H8enXNmJsQYCD

Possible fixes

(Any comments on what you think might be responsible for the problem, if you have particular insight.)

/cc @artem