GitLab

Summary

QA: nftproto register does not validate maxMetaDataSize according to the rules given in the help

Steps to reproduce

mark@x230:~/.crowntest/testnet3$ tcrowncli nftproto register nine test9 tCRWPpEZVu93MVGYS9FqEjV9XAW9sgKz3MMTp 2 "-" "-" TrUe 0 -1
83da8c19b57831db359f22ac7dd1d6ca22091fcc693a01fc4276d22c8bfca715
mark@x230:~/.crowntest/testnet3$ tcrowncli nftproto register ninea test9 tCRWPpEZVu93MVGYS9FqEjV9XAW9sgKz3MMTp 2 "-" "-" TrUe 0 0
1bb10e5baad56313961eb1160c23563c2198ffae0ed6efc7fc935ba644d03d6f
mark@x230:~/.crowntest/testnet3$ tcrowncli nftproto register nineb test9 tCRWPpEZVu93MVGYS9FqEjV9XAW9sgKz3MMTp 2 "-" "-" TrUe 0 256
d3042a9ae18645218704f9b31374b4255fa822430349ac0dab281357afb9e51c
mark@x230:~/.crowntest/testnet3$ tcrowncli nftproto register ninec test9 tCRWPpEZVu93MVGYS9FqEjV9XAW9sgKz3MMTp 2 "-" "-" TrUe 0 1024
b9da4d9e64336b7acd7d957fc2dfcdfea1b905768c4cf391eca9b04577a8aab5

Expected behavior

All of the above should all have been rejected

Problematic behavior

All of the above were accepted

Crown-core environment info

Ubuntu 16.04

Crown-core application info

v0.13.9.3 build 1166

Relevant logs, dumps and/or screenshots

(Paste any relevant logs - please use code blocks (```) to format console output, logs, and code; it's very hard to read otherwise.)

Drop full logs & dumps here: https://nextcloud.crownplatform.com/index.php/s/Q6H8enXNmJsQYCD

Possible fixes

(Any comments on what you think might be responsible for the problem, if you have particular insight.)

/cc @artem