Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • crown-core crown-core
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 75
    • Issues 75
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Crown
  • crown-corecrown-core
  • Merge requests
  • !106

Merged
Created Apr 25, 2018 by Volodymyr Shamray@vshamrayReporter

Resolve "Order-agnostic comparison for Finalized budgets"

  • Overview 15
  • Commits 21
  • Pipelines 15
  • Changes 11

Closes #139 (closed)

  • Changed CFinalizedBudget to always store payments sorted by payment amount
  • Modified CFinalizedBudget::GetHash() to be more tolerant of differences
  • Removed budgetvotemode="auto" check. Now all Masternodes are bound to auto-vote
  • Added new spork key to force disconnect old peers (instead of cutting them off immediately). Please review this with special attention
  • Modified CFinalizedBudget::AutoCheck() to compare budgets with regards to new ordering
  • Added unit tests that cover new functionality. Please review them carefully to make sure they are readable and easy to understand
Edited Apr 30, 2018 by Volodymyr Shamray
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 139-impl-finalbudget-order-agnostic-comparison