Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • crown-core crown-core
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 75
    • Issues 75
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Crown
  • crown-corecrown-core
  • Merge requests
  • !80

Merged
Created Jan 25, 2018 by Volodymyr Shamray@vshamrayReporter

Resolve "Governance doesn't work properly in testnet"

  • Overview 5
  • Commits 21
  • Changes 8

Closes #110 (closed)

  1. Fixed integer arithmetics in CBudgetManager::IsTransactionValid and CBudgetManager::IsBudgetPaymentBlock
  2. Made finalized budget to be submitted 8 blocks before the superblock instead of 2
  3. Reduced time for proposal to be established to 15 minutes
  4. Reduced target timespan for testnet to 6 hours. I expect it will make network to adjust difficulty more often and facilitate testing

Also refactored a few pieces of code:

  • Added const to some methods and parameters
  • Removed exception specifications which fixes warnings on modern compilers
  • Improved CBudgetDB constructor
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 110-testnet-fix