Fix #650: CKey::SetSecret BIGNUM leak

fafcbf0d · Pieter Wuille · de1a4d95 · fafcbf0d
Commit fafcbf0d authored 13 years ago by Pieter Wuille
Hide whitespace changes
Inline Side-by-side

Showing

with 4 additions and 1 deletion
+4 -1
--- a/src/key.h
+++ b/src/key.h
@@ -141,10 +141,13 @@ public:
        if (vchSecret.size() != 32)
            throw key_error("CKey::SetSecret() : secret must be 32 bytes");
        BIGNUM *bn = BN_bin2bn(&vchSecret[0],32,BN_new());
-        if (bn == NULL) 
+        if (bn == NULL)
            throw key_error("CKey::SetSecret() : BN_bin2bn failed");
        if (!EC_KEY_regenerate_key(pkey,bn))
+        {
+            BN_clear_free(bn);
            throw key_error("CKey::SetSecret() : EC_KEY_regenerate_key failed");
+        }
        BN_clear_free(bn);
        fSet = true;
        if (fCompressed || fCompressedPubKey)