GitLab

2bb1c877 refactor: move bdb (bitdb) interaction from init.cpp to wallet.cpp (Jonas Schnelli)

this will remove db.h from init.cpp

50c72f23 [Move Only] Move wallet related things to src/wallet/ (Jonas Schnelli)

d7d187e8 allocators: split allocators and pagelocker (Cory Fields)

Pagelocker is only needed for secure (usually wallet) operations, so don't make
the zero-after-free allocator depend on it.

adaa5687 Add script to verify all merge commits are signed (Matt Corallo)

71acb865 print the caught error instead of raising an error (Heath)

9c273790 Reduce fingerprinting through timestamps in 'addr' messages. (Pieter Wuille)

Suggested by Jonas Nick.

bb44d9e7 depends: fix a static qt5 crash when using certain versions of libxcb (Cory Fields)

See here for background: https://bugreports.qt.io/browse/QTBUG-34748

libxcb temporarily had an abi breakage which caused crashes when qt was
compiled against a non-compatible version. Building qt with -qt-xcb should have
shielded us from this issue, except that incompatible headers were used when
building qt's wrapper.

Make sure those headers aren't picked up by qt's build.

Details:

qt's build adds a wrapper around the xcb libs when -qt-xcb is used. This is
done to avoid having to link to a handful of different libs, which may not be
api/abi stable. This build depends on include-order, so that its files are
found before the real libxcb headers.

Our build (for other reasons related to qt's complicated build-system) injects
our prefix into CXXFLAGS. Because libxcb is found in this path, that reverses
the include-order, negating the purpose of the wrapper.

To fix, libxcb's includes are simply moved to a subdir. pkg-config ensures that
they're still found properly when needed.

To make things even more interesting, this behavior in qt's .pro files is broken:
INCLUDEPATH += $$QMAKE_CFLAGS_XCB

The INCLUDEPATH variable is processed by qmake which automatically prefixes each
entry with "-I". The QMAKE_CFLAGS_XCB variable comes from pkg-config and
already contains -I, making the path look like "-I-I/path/to/xcb/headers".

To work around that, CFLAGS/CXXFLAGS are used here rather than INCLUDEPATH.

8b60808c [QT] some mac specifiy cleanup (memory handling, unnecessary code) (Jonas Schnelli)
89e70e93 [QT] fix OSX dock icon window reopening (Jonas Schnelli)

723664b5 startup script for centos, with documentation. (joshr)

1d9b378c qa/rpc-tests/wallet: Tests for sendmany (Luke Dashjr)
40a75733 rpcwallet/sendmany: Just take an array of addresses to subtract fees from, rather than an Object with all values being identical (Luke Dashjr)
292623ad Subtract fee from amount (Cozz Lovan)
90a43c1e [Qt] Code-movement-only: Format confirmation message in sendcoinsdialog (Cozz Lovan)

3c6d594e contrib/init/bitcoind.openrc: Compatibility with previous OpenRC init script variables (Luke Dashjr)

rpcwallet/sendmany: Just take an array of addresses to subtract fees from, rather than an Object with all values being identical

Fixes #2724 and #1570.

Adds the
automatically-subtract-the-fee-from-the-amount-and-send-whats-left
feature to the GUI and RPC (sendtoaddress,sendmany).

e96c5184 BUGFIX: Stack around the variable 'rv' was corrupted (fsb4000)

88f6c8c3 add RPC test for InvalidateBlock (Alex Morcos)
a9af4158 fix InvalidateBlock to repopulate setBlockIndexCandidates (Alex Morcos)

could once be renamed from /src/wallet to /src/legacywallet.

9519a9a4 Add correct bool combiner for net signals (Pieter Wuille)

92fd887f tests: add a BasicTestingSetup and apply to all tests (Wladimir J. van der Laan)

Make sure that chainparams and logging is properly initialized. Doing
this for every test may be overkill, but this initialization is so
simple that that does not matter.

This should fix the travis issues.

fixes #5878

3aa0130b test: remove fSkipProofOfWork (Wladimir J. van der Laan)
59bd89f1 test: Remove UNITTEST params (Wladimir J. van der Laan)

f7547079 Fix - bitcoin-qt usage message (Luca Venturini)
1fdb9fa3 Help messages correctly formatted (79 chars) (Luca Venturini)

bb6acff0 fix possible block db breakage during re-index (Cory Fields)

. Closes the bug from commit e179eb3d
("bitcoin-qt -help" did not show any message)
. Move all the options in init.cpp (there were already some
options related to bitcoin-qt)

Help messages are formatted programmatically with FormatParagraph
in order not to break existing strings in Transifex.

The new format works even if the translation of the strings
modifies the lenght of the message.

Sqashed 6 commits in a single one.
Help messages correctly formatted for SVGA text mode (132 chars)

Help messages are formatted programmatically with FormatParagraph
in order not to break existing strings in Transifex.

The new format should work even if the translation of the strings
modifies the lenght of the message.

Fix - syntax error

Correct formatting for 79 chars

Correctly based on C++ functions

Removed spare spaces from option strings

Fix - syntax error

When re-indexing, there are a few cases where garbage data may be skipped in
the block files. In these cases, the indices are correctly written to the index
db, however the pointer to the next position for writing in the current block
file is calculated by adding the sizes of the valid blocks found.

As a result, when the re-index is finished, the index db is correct for all
existing blocks, but the next block will be written to an incorrect offset,
likely overwriting existing blocks.

Rather than using the sum of all valid blocks to determine the next write
position, use the end of the last block written to the file. Don't assume that
the current block is the last one in the file, since they may be read
out-of-order.

Not used, and REGTEST already allows creating blocks at
the lowerst possible difficulty.

UNITTEST parameter are not used by any current tests, and the model
(modifyable parameters) is inconvenient when unit-testing. As
they are stored in a global structure eevery test
would have to (re)set up its own parameters.

For consistency it is also better to test with MAIN parameters.

Avoid this travis error:

    test_bitcoin: chainparams.cpp:330: const CChainParams& Params():
    Assertion `pCurrentParams' failed.
    unknown location(0): fatal error in "subsidy_limit_test": signal:
    SIGABRT (application abort requested)
    test/allocator_tests.cpp(116): last checkpoint

51598b26 Reinitialize state in between individual unit tests. (Pieter Wuille)