GitLab

7179e7ca qt: Periodic translations update (Wladimir J. van der Laan)
5e903a5e devtools: Handle Qt formatting characters edge-case in update-translations.py (Wladimir J. van der Laan)

a60677e3 Pre-0.14.0 hardcoded seeds update (Wladimir J. van der Laan)
bfa9393c contrib/seeds: Update PATTERN_AGENT (Wladimir J. van der Laan)
4dfac2c9 Update seeds tooling to Python 3 (Wladimir J. van der Laan)

db2dc7a5 Move CNode::addrLocal access behind locked accessors (Matt Corallo)
036073bf Move CNode::addrName accesses behind locked accessors (Matt Corallo)
d8f2b8a8 Make nTimeBestReceived atomic (Matt Corallo)
22b4966a Move [clean|str]SubVer writes/copyStats into a lock (Matt Corallo)
0f318726 Make nServices atomic (Matt Corallo)
96f42d8a Make nStartingHeight atomic (Matt Corallo)
512731be Access fRelayTxes with cs_filter lock in copyStats (Matt Corallo)
ae683c1b Avoid copying CNodeStats to make helgrind OK with buggy std::string (Matt Corallo)
644f1234 Make nTimeConnected const in CNode (Matt Corallo)
321d0fc6 net: fix a few races. Credit @TheBlueMatt (Cory Fields)

9db8eeca Fix RPC failure testing (John Newbery)

These are (afaik) all long-standing races or concurrent accesses. Going
forward, we can clean these up so that they're not all individual atomic
accesses.

- Reintroduce cs_vRecv to guard receive-specific vars
- Lock vRecv/vSend for CNodeStats
- Make some vars atomic.
- Only set the connection time in CNode's constructor so that it doesn't change

9a0b784d net: add a lock around hSocket (Cory Fields)
45e2e085 net: rearrange so that socket accesses can be grouped together (Cory Fields)

gmaxwell: Adds the newest versions, drops everything multiple softforks ago.

All the other tooling scripts require Python 3, it makes sense to do so
here too.

Also document the dependency on python3-dnspython.

If both numeric format specifiers and "others" are used, assume we're
dealing with a Qt-formatted message. In the case of Qt formatting (see
https://doc.qt.io/qt-5/qstring.html#arg) only numeric formats are
replaced at all. This means "(percentage: %1%)" is valid (which was
introduced in #9461), without needing any kind of escaping that would be
necessary for strprintf.  Without this, this function would wrongly
detect '%)' as a printf format specifier.

ca9955e7 Remove bitseed.xf2.org form the dns seed list (Jonas Schnelli)

a9baa6d7 Bugfix: Qt/Intro: Pruned nodes never require *more* space (Luke Dashjr)
93ffba71 Bugfix: Qt/Intro: Chain state needs to be stored even with the full blockchain (Luke Dashjr)
c8cee261 Qt/Intro: Update block chain size (Luke Dashjr)

Make sure that RPC tests are actually checking failures correctly by:

- Catching JSON RPC exceptions and verifying the error codes and messages.
- Failing the test case if the JSON RPC exception isn't raised.

618ee924 Further-enforce lockordering by enforcing directly after TRY_LOCKs (Matt Corallo)
2a962d45 Fixup style a bit by moving { to the same line as if statements (Matt Corallo)
84656318 Always enforce lock strict lock ordering (try or not) (Matt Corallo)
fd13eca1 Lock cs_vSend and cs_inventory in a consistent order even in TRY (Matt Corallo)

5cc2ebb6 Update OpenBSD and FreeBSD build steps (Wladimir J. van der Laan)
8713de83 build: Add options to override BDB cflags/libs (Wladimir J. van der Laan)

29c53289 bench: Fix initialization order in registration (Wladimir J. van der Laan)

The initialization order of global data structures in different
implementation units is undefined. Making use of this is essentially
gambling on what the linker does, the so-called [Static initialization
order fiasco](https://isocpp.org/wiki/faq/ctors#static-init-order).

In this case it apparently worked on Linux but failed on OpenBSD and
FreeBSD.

To create it on first use, make the registration structure local to
a function.

Fixes #8910.

90fd29bd Remove unused int64_t nSinceLastSeen (practicalswift)
ac4a0953 Remove unused Python variables (practicalswift)

dd5b0114 [Trivial] add comment about setting peer as HB peer. (John Newbery)

Re-try with most recent versions, and use BDB_CFLAGS/BDB_LIBS to
directly point at BerkeleyDB instead of CPPFLAGS hacks.

Add environment settings to specify the CFLAGS and LIBS to be used for
BerkeleyDB directly. These will completely by-pass autodetection in the
same way as other similar flags.

```
BDB_CFLAGS  C compiler flags for BerkeleyDB, bypasses autodetection
BDB_LIBS    Linker flags for BerkeleyDB, bypasses autodetection
```

Implements #3921.

d63ff626 Make nWalletDBUpdated atomic to avoid a potential race. (Patrick Strateman)

39c77b00 Add documentation for CWalletTx::fFromMe member. (Russell Yanofsky)