- 02 Apr, 2014 1 commit
-
-
Cozz Lovan authored
-
- 11 Mar, 2014 1 commit
-
-
Cozz Lovan authored
-
- 26 Feb, 2014 1 commit
-
-
Gavin Andresen authored
Use the spent outpoint multimap to figure out which wallet transaction outputs are unspent, instead of a vfSpent array that is saved to disk.
-
- 24 Feb, 2014 1 commit
-
-
Wladimir J. van der Laan authored
Amend to d5f1e727. It turns out that BerkelyDB was including inttypes.h indirectly, so we cannot fix this with just macros. Trivial commit: apply the following script to all .cpp and .h files: # Middle sed -i 's/"PRIx64"/x/g' "$1" sed -i 's/"PRIu64"/u/g' "$1" sed -i 's/"PRId64"/d/g' "$1" # Initial sed -i 's/PRIx64"/"x/g' "$1" sed -i 's/PRIu64"/"u/g' "$1" sed -i 's/PRId64"/"d/g' "$1" # Trailing sed -i 's/"PRIx64/x"/g' "$1" sed -i 's/"PRIu64/u"/g' "$1" sed -i 's/"PRId64/d"/g' "$1" After this commit, `git grep` for PRI.64 should turn up nothing except the defines in util.h.
-
- 22 Feb, 2014 1 commit
-
-
Wladimir J. van der Laan authored
As the tinyformat-based formatting system (introduced in b77dfdc9) is type-safe, no special format characters are needed to specify sizes. Tinyformat can support (ignore) the C99 prefixes such as "ll" but chokes on MSVC's inttypes.h defines prefixes such as "I64X". So don't include inttypes.h and define our own for compatibility. (an alternative would be to sweep the entire codebase using sed -i to get rid of the size specifiers but this has less diff impact)
-
- 20 Feb, 2014 1 commit
-
-
R E Broadley authored
-
- 18 Feb, 2014 1 commit
-
-
Gavin Andresen authored
Compiling with -DDEBUG_LOCKORDER and running the qa/rpc-test/ regression tests uncovered a couple of wallet methods that should (but didn't) acquire the cs_wallet mutext. I also changed the AssertLockHeld() routine print to stderr and abort, instead of printing to debug.log and then assert()'ing. It is annoying to look in debug.log to find out which AssertLockHeld is failing.
-
- 14 Feb, 2014 3 commits
-
-
Gavin Andresen authored
Adds a "walletconflicts" array to transaction info; if a wallet transaction is mutated, the alternate transaction id or ids are reported there (usually the array will be empty). Metadata from the original transaction is copied to the mutant, so the transaction time and "from" account of the mutant are reported correctly.
-
Jeff Garzik authored
This diagnostic tool removes all "tx" records from the wallet db, then forces a full rescan, to rebuild "tx" records accurately.
-
Gavin Andresen authored
Extend CMerkleTx::GetDepthInMainChain with the concept of a "conflicted" transaction-- a transaction generated by the wallet that is not in the main chain or in the mempool, and, therefore, will likely never be confirmed. GetDepthInMainChain() now returns -1 for conflicted transactions (0 for unconfirmed-but-in-the-mempool, and >1 for confirmed). This makes getbalance, getbalance '*', and listunspent all agree when there are mutated transactions in the wallet. Before: listunspent: one 49BTC output getbalance: 96 BTC (change counted twice) getbalance '*': 46 BTC (spends counted twice) After: all agree, 49 BTC available to spend.
-
- 13 Feb, 2014 1 commit
-
-
Gregory Maxwell authored
This doesn't change the functionality at all.
-
- 11 Feb, 2014 1 commit
-
-
Wladimir J. van der Laan authored
-
- 10 Feb, 2014 1 commit
-
-
gubatron authored
contrib/devtools/fix-copyright-headers.py script to be able to perform this maintenance task with ease during the rest of the year, every year. Modifications to contrib/devtools/README.md to document what fix-copyright-headers.py does.
-
- 07 Feb, 2014 1 commit
-
-
Cozz Lovan authored
-
- 23 Jan, 2014 1 commit
-
-
Wladimir J. van der Laan authored
After the tinyformat switch sprintf() family functions support passing actual std::string objects. Remove unnecessary c_str calls (236 of them) in logging and formatting.
-
- 19 Jan, 2014 2 commits
-
-
Cozz Lovan authored
-
Wladimir J. van der Laan authored
-
- 19 Dec, 2013 2 commits
-
-
Wladimir J. van der Laan authored
Make the function mutex-aware, to prevent having to lock cs_wallet at the call site in Init.
-
Wladimir J. van der Laan authored
Add locking assertions to wallet to all methods that access internal fields and do not aquire the cs_wallet mutex.
-
- 14 Dec, 2013 1 commit
-
-
Wladimir J. van der Laan authored
ThreadSafeAskFee is effectively unused. It is only called when the fAskFee parameter on SendMoney or SendMoneyToDestination is true, which never happens. Remove it.
-
- 13 Dec, 2013 1 commit
-
-
Wladimir J. van der Laan authored
Transaction fee is only used by the wallet. No need for it to be in main.cpp.
-
- 04 Dec, 2013 2 commits
-
-
Wladimir J. van der Laan authored
Versions of bitcoin before 0.8.6 have a bug that inserted empty transactions into the vtxPrev in the wallet, which will cause the node to be banned when retransmitted, hence add a check for !tx.vin.empty() before RelayTransaction.
-
Wladimir J. van der Laan authored
CWalletTx::AddSupportingTransactions() was adding empty transaction to vtxPrev in some cases. Skip over these. Part one of the solution to #3190. This prevents invalid vtxPrev from entering the wallet, but not current ones being transmitted.
-
- 02 Dec, 2013 1 commit
-
-
Gregory Maxwell authored
There were quite a few places where assert() was used with side effects, making operation with NDEBUG non-functional. This commit fixes all the cases I know about, but also adds an #error on NDEBUG because the code is untested without assertions and may still have vulnerabilities if used without assert.
-
- 30 Nov, 2013 2 commits
-
-
Gavin Andresen authored
Also changes mempool to store CTxMemPoolEntries to keep track of when they enter/exit the pool.
-
Gavin Andresen authored
GetValueIn makes more sense as a CTransaction member.
-
- 18 Nov, 2013 1 commit
-
-
Philip Kaufmann authored
- add missing license headers - make compatible with Qt5 - enforce header cleanup style - small code style cleanups - rename Coin Control dialog into Coin Control Address Selection - use default font for the windows labels (no monospace)
-
- 15 Nov, 2013 1 commit
-
-
Philip Kaufmann authored
- example: if util.h includes stdint.h, remove it from util.cpp, as util.h is the first header included in util.cpp
-
- 14 Nov, 2013 2 commits
-
-
Cozz Lovan authored
-
Cozz Lovan authored
-
- 10 Nov, 2013 1 commit
-
-
Brandon Dahler authored
Use misc methods of avoiding unnecesary header includes. Replace int typedefs with int##_t from stdint.h. Replace PRI64[xdu] with PRI[xdu]64 from inttypes.h. Normalize QT_VERSION ifs where possible. Resolve some indirect dependencies as direct ones. Remove extern declarations from .cpp files.
-
- 26 Oct, 2013 4 commits
-
-
Pieter Wuille authored
This required some code movement (what was CWalletTx::AcceptToMemoryPool doing in main?), and adding a few explicit includes that used to be implicit through init.h.
-
Pieter Wuille authored
-
Pieter Wuille authored
-
Pieter Wuille authored
-
- 20 Oct, 2013 1 commit
-
-
super3 authored
-
- 11 Oct, 2013 1 commit
-
-
Pieter Wuille authored
-
- 10 Oct, 2013 1 commit
-
-
Wladimir J. van der Laan authored
-
- 04 Oct, 2013 1 commit
-
-
Gavin Andresen authored
Remove the (relay/mempool) rule that all outputs of free transactions must be greater than 0.01 XBT. Dust spam is now taken care of by making dusty outputs non-standard.
-
- 20 Sep, 2013 1 commit
-
-
Philip Kaufmann authored
-