GitLab

There is still a redundancy here between configure.ac and
clientversion.h.

Rebased-From: edbc9045

The normative place for these for the entire project is COPYING,
and the main README already has a MIT license section.

Rebased-From: e6df2bb4

- Avoid ambiguous language regarding when transactions confirm
- Elaborate on downgrading warning
- Other minor language improvements
- Clarify watch-only behaviour

Github-Pull: #5534

Besides giving a nicer error, this also prevents logging arbitrary data (which could have been used to exploit log readers) into debug.log

Rebased-From: 7f718139
Github-Pull: #5499

I'm not comfortable with retaining this entry.

Rebased-From: a094b3d9
Github-Pull: #5545

Rebased-From: 06206bb3
Github-Pull: 5571

Rebased-From: f9c571aa
Github-Pull: #5565

Rebased-From: a15dba5d
Github-Pull: #5533

Rebased-From: 566c6cb8
Github-Pull: #5536

Previously an empty script wouldn't be hashed, and CScriptID would be
assigned the incorrect value of 0 instead. This bug can be seen in the
RPC decodescript command:

    $ btc decodescript ""
    {
        "asm" : "",
        "type" : "nonstandard",
        "p2sh" : "31h1vYVSYuKP6AhS86fbRdMw9XHieotbST"
    }

Correct output:

    $ btc decodescript ""
    {
        "asm" : "",
        "type" : "nonstandard",
        "p2sh" : "3J98t1WpEZ73CNmQviecrnyiWrnqRhWNLy"
    }

Rebased-From: d78f0daf
Github-Pull: #5541

Github-Pull: #5512
Rebased-From: dd14a0e7

Don't allow immediate inv driven block downloads if
a peer already has MAX_BLOCKS_IN_TRANSIT_PER_PEER
active downloads.  Prevents bogus inv spam from
blowing up block transfer tracking data structures.

Rebased-From: c9077043
Github-Pull: #5507

'Sane' was already defined by this code as:
 fee.GetFeePerK() > minRelayFee.GetFeePerK() * 10000
 But sanity was only enforced for data loaded from disk.

Note that this is a pretty expansive definition of 'sane': A 10 BTC
 fee is still passes the test if its on a 100kb transaction.

This prevents a single insane fee on the network from making us reject
 our stored fee data at start.  We still may reject valid saved fee
 state if minRelayFee is changed between executions.

This also reduces the risk and limits the damage from a cascading
 failure where one party pays a bunch of insane fees which cases
 others to pay insane fees.

Rebased-From: 64849306
Github-Pull: #5481

Previously the minRelayTxFee was only enforced on user specified values.

It was possible for smartfee to produce a fee below minRelayTxFee which
 would just result in the transaction getting stuck because it can't be
 relayed.

This also introduces a maxtxfee option which sets an absolute maximum
 for any fee created by the wallet, with an intention of increasing
 user confidence that the automatic fees won't burn them. This was
 frequently a concern even before smartfees.

If the configured fee policy won't even allow the wallet to meet the relay
 fee the transaction creation may be aborted.

Rebased-From: aa279d61
Github-Pull: #5485

Rebased-From: 34970223
Github-Pull: #5459

Rebased-From: 4bc95c43

Previously transactions were only tested again the
STANDARD_SCRIPT_VERIFY_FLAGS prior to mempool acceptance, so any bugs in
those flags that allowed actually-invalid transactions to pass would
result in allowing invalid transactions into the mempool. Fortunately
there is a second check in CreateNewBlock() that would prevent those
transactions from being mined, resulting in an invalid block, however
this could still be exploited as a DoS attack.

Rebased-From: 7c041b3b

Rebased-From: 84857e87
Github-Pull: #5437

Bump version but keep CLIENT_VERSION_IS_RELEASE at false as this is not
a release yet.

Rebased-From: 164a45f5
Github-Pull: #5471

Github-Pull: #5461
Rebased-From: aa768f18

Github-Pull: #5465
Rebased-From: 422f873e d546191d d7db4b63 e27d7cb2

34318d7f RPC-test based on invalidateblock for mempool coinbase spends (Gavin Andresen)
7fd6219a Make CTxMemPool::remove more effecient by avoiding recursion (Matt Corallo)
b7b4318f Make CTxMemPool::check more thourough by using CheckInputs (Matt Corallo)
723d12c0 Remove txn which are invalidated by coinbase maturity during reorg (Matt Corallo)
868d0416 Remove coinbase-dependant transactions during reorg. (Matt Corallo)

932ef50f [REST] JSON output: remove block infos from tx details if it is nested in block (Jonas Schnelli)
cae54868 [REST] added /rest/block/notxdetails/<hash> into REST-interface.md documentation (Jonas Schnelli)
73351c36 [REST] /rest/block response with full tx details (Jonas Schnelli)

4be639ea Use RPC_INVALID_PARAMETER instead of RPC_WALLET_ERROR for invalid amount. No return at the end of void function. (Pavel Janík)
b93173de Move SendMoney() to rpcwallet.cpp. (Pavel Janík)

4c69ebed Add /opt/local/include/db48 only if it exists. (Pavel Janík)