1. 23 Apr, 2012 1 commit
  2. 21 Apr, 2012 1 commit
  3. 18 Apr, 2012 1 commit
    • Dwayne C. Litzenberger's avatar
      Fix bugs on 'unsigned char' platforms. · 6c784435
      Dwayne C. Litzenberger authored
      In ISO C++, the signedness of 'char' is undefined.  On some platforms (e.g.
      ARM), 'char' is an unsigned type, but some of the code relies on 'char' being
      signed (as it is on x86).  This is indicated by compiler warnings like this:
      
       bignum.h: In constructor 'CBigNum::CBigNum(char)':
       bignum.h:81:59: warning: comparison is always true due to limited range of data type [-Wtype-limits]
      
       util.cpp: In function 'bool IsHex(const string&)':
       util.cpp:427:28: warning: comparison is always false due to limited range of data type [-Wtype-limits]
      
      In particular, IsHex erroneously returned true regardless of the input
      characters, as long as the length of the string was a positive multiple of 2.
      
      Note: For testing, it's possible using GCC to force char to be unsigned by
      adding the -funsigned-char parameter to xCXXFLAGS.
      6c784435
  4. 26 Mar, 2012 1 commit
  5. 07 Feb, 2012 1 commit
  6. 19 Jan, 2012 1 commit
  7. 13 Jan, 2012 2 commits
  8. 22 Dec, 2011 1 commit
  9. 21 Dec, 2011 1 commit
  10. 20 Dec, 2011 1 commit
  11. 19 Dec, 2011 3 commits
  12. 09 Aug, 2011 1 commit
    • Matt Corallo's avatar
      Unify copyright notices. · b2120e22
      Matt Corallo authored
      To a variation on:
      // Copyright (c) 2009-2010 Satoshi Nakamoto
      // Copyright (c) 2011 The Bitcoin developers
      b2120e22
  13. 08 Aug, 2011 2 commits
  14. 17 Jul, 2011 2 commits
    • Pieter Wuille's avatar
      Use CBitcoinAddress instead of string/uint160 · 2ffba736
      Pieter Wuille authored
      Instead of conversion functions between pubkey/uint160/address in
      base58.h, have a fully fledged class CBitcoinAddress (CAddress was
      already taken) to represent addresses.
      2ffba736
    • Pieter Wuille's avatar
      get rid of mapPubKeys · 03fbd790
      Pieter Wuille authored
      Make CKeyStore's interface work on uint160's instead of pubkeys, so
      no separate global mapPubKeys is necessary anymore.
      03fbd790
  15. 13 Jul, 2011 1 commit
    • Giel van Schijndel's avatar
      fix warnings: expression result unused [-Wunused-value] · ecf1c79a
      Giel van Schijndel authored
      
      In the assert()s take advantage of the fact that string constants
      ("string") are effectively of type 'const char []', which when used in
      an expression yield a non-NULL pointer.
      
      An assertion that should always fail can thus be formulated as:
        assert(!"fail);
      
      An assertion where a text message should be added to the expression can
      be written as such:
        assert("message" && expression);
      Signed-off-by: default avatarGiel van Schijndel <me@mortis.eu>
      ecf1c79a
  16. 26 Jun, 2011 1 commit
  17. 15 Jun, 2011 2 commits
    • Pieter Wuille's avatar
      CWallet class · 64c7ee7e
      Pieter Wuille authored
      * A new class CKeyStore manages private keys, and script.cpp depends on access to CKeyStore.
      * A new class CWallet extends CKeyStore, and contains all former wallet-specific globals; CWallet depends on script.cpp, not the other way around.
      * Wallet-specific functions in CTransaction/CTxIn/CTxOut (GetDebit, GetCredit, GetChange, IsMine, IsFromMe), are moved to CWallet, taking their former 'this' argument as an explicit parameter
      * CWalletTx objects know which CWallet they belong to, for convenience, so they have their own direct (and caching) GetDebit/... functions.
      * Some code was moved from CWalletDB to CWallet, such as handling of reserve keys.
      * Main.cpp keeps a set of all 'registered' wallets, which should be informed about updates to the block chain, and does not have any notion about any 'main' wallet. Function in main.cpp that require a wallet (such as GenerateCoins), take an explicit CWallet* argument.
      * The actual CWallet instance used by the application is defined in init.cpp as "CWallet* pwalletMain". rpc.cpp and ui.cpp use this variable.
      * Functions in main.cpp and db.cpp that are not used by other modules are marked static.
      * The code for handling the 'submitorder' message is removed, as it not really compatible with the idea that a node is independent from the wallet(s) connected to it, and obsolete anyway.
      64c7ee7e
    • Pieter Wuille's avatar
      move wallet code to separate file · e89b9f6a
      Pieter Wuille authored
      This introduces two new source files, keystore.cpp and wallet.cpp with
      corresponding headers. Code is moved from main and db, in a preparation
      for a follow-up commit which introduces the classes CWallet and CKeyStore.
      e89b9f6a
  18. 11 Jun, 2011 1 commit
  19. 14 May, 2011 1 commit