GitLab

Cbitcoinaddress

Fix typo in CBase58Data::CompareTo

Split off features unrelated to addresses from CBitcoinAddress to
CBase58Data, so they can be reused.

Instead of conversion functions between pubkey/uint160/address in
base58.h, have a fully fledged class CBitcoinAddress (CAddress was
already taken) to represent addresses.

Make CKeyStore's interface work on uint160's instead of pubkeys, so
no separate global mapPubKeys is necessary anymore.

Update makefile.vc for wallet encryptions.

added polish wallet encryption messages

Fix bad return values in LoadWallet.

Single DB transactions

Fix Build in GetReservedKey() in wallet.cpp

Generate Warning when using default key.

Cuts disk activity at startup immensely

Fix crashes when a wallet is locked and GetReservedKey() is called

Warning fixes

Bugfix: add autogenerated addresses to address book

Signed-off-by: Giel van Schijndel <me@mortis.eu>

Signed-off-by: Giel van Schijndel <me@mortis.eu>

Fix makefile.linux-mingw

Yes, we might release as v0.4, but let's just do a simple increment
for now.

Warning fixes

Only declare & define SigIllHandlerSSE2 when its used.
Signed-off-by: Giel van Schijndel <me@mortis.eu>

Remove several unused variables.
Signed-off-by: Giel van Schijndel <me@mortis.eu>

Add default cases to opcode switches to assert that they should never
occur.
Signed-off-by: Giel van Schijndel <me@mortis.eu>

Don't check for a negative parameter count, because not only will it
never happen, it doesn't make any sense either.

Invalid sockets (as returned by socket(2)) are always exactly -1 (not
just negative as negative file descriptors are technically not
prohibited by POSIX) on POSIX systems.  Since we store them in SOCKET
(unsigned int), however, that really is ~0U (or MAX_UINT) which happens
to be what INVALID_SOCKET is already defined to, so an additional check
for being negative is not only unnecessary (unsigned integers aren't
*ever* negative) its redundant as well (the INVALID_SOCKET comparison is
enough).
Signed-off-by: Giel van Schijndel <me@mortis.eu>

Don't unnecessarily assign to variables within the *boolean* expression
of a conditional.
Signed-off-by: Giel van Schijndel <me@mortis.eu>

In the assert()s take advantage of the fact that string constants
("string") are effectively of type 'const char []', which when used in
an expression yield a non-NULL pointer.

An assertion that should always fail can thus be formulated as:
  assert(!"fail);

An assertion where a text message should be added to the expression can
be written as such:
  assert("message" && expression);
Signed-off-by: Giel van Schijndel <me@mortis.eu>

fix warning on 64bit systems: cast to pointer from integer of different size [-Wint-to-pointer-cast]
Signed-off-by: Giel van Schijndel <me@mortis.eu>

Add minversion to wallet.