GitLab

Remove redundant insert method in serialize

Generalize the remove-outputs check for fully-prunable transactions.

Instead of explicitly testing for the presence of any output, and
dealing with this case specially, just interpret it as an empty
CCoins.

The case previously caught using the HaveCoins check, is now handled
by the generic outs != outsBlock test.

Use a GridLayout instead of a FormLayout. This makes the alignment
of the labels consistent between the tabs.

Missed RPC port

Re-enable Jenkins and run more tests on Jenkins than pull-tester gets

Re-enable BitcoindComparisonTool on pull-tester

GUIUtil: make getSaveFileName() use native OS path separators

qt: english language update

[Qt] additional small fixes for #3099 (new receive flow)

qt: clean up signal handling in walletframe/walletview

Use proper signals everywhere.
Removes the need to store a pointer to the BitcoinGUI object in
the walletview.
Also removes the interdependence between setWalletModel / setBitcoinGUI.

 * Use the latest version, with limited memory usage, and path to
   on-disk db (try mouting qa/tmp on a tmpfs)\
 * enable -debug=net
 * re-enable BitcoindComparisonTool in pull-tester

- remove 2 unneeded windowTitle attributes, which bloat our translations
- cleanup some unneeded .cpp/.h includes and class usages
- use a more generic string for clearing sendcoinsdialog and
  requestpaymentdialog
- edit 2 strings in BitcoinGUI and replace "edit" with "show" as this
  seems more clear in the context where it is used

This seems to cause problems on recent clang, and looks totally
redundant and unused.

The const_iterator version is identical to the vector::const_iterator
one (which is a typedef thereof). Marking it private (instead of
removing) compiles fine, so this version is effectively unused even.

1f3d3647 Send multiple inv messages if mempool.size > MAX_INV_SZ (Gavin Andresen)

Changes the response to the 'mempool' command so that if
the memory pool has more than MAX_INV_SZ transactions (50,000)
it will respond with multiple 'inv' messages.

allow emit message() in sendcoinsdialog and walletview

They're supposed to be children of the walletview, and are added with
addWidget later on.
Inconsequential change because the object passed was already 0.

[Qt] additional small fix for #3099 (new receive flow)

- remove an obsolete connection to a signMessage() signal

[Qt] misc small fixes for #3099 (new receive flow)

- changes some strings that were forgotton or made no sense in the conext
  they are used
- remove an orphan file from the qt project file
- revert a small change in signverifymessagedialog.ui
- guard #include "bitcoin-config.h" with #if defined(HAVE_CONFIG_H)
- remove windowTitle from addressbookpage.ui

- this allows us to use emit message() over MessageBox:: or gui->message()
  calls in sendcoinsdialog and walletview
- move main handlePaymentRequest() functionality back to BitcoinGUI
- move a showNormalIfMinimized() before gotoSendCoinsPage()

qt: improve "receive coins" workflow

- We no longer have an address book, but "address lists", update message
  accordingly
- Add tooltips here and there
- Clarify text on buttons
- add Copy Address button to receive request dialog

Qt: move paymentACK handling to paymentserver

paymentserver: init all class members in constructor

- add new slot handlePaymentACK() to paymentserver, which handles
  paymentACK messages (currently we just display them)
- make paymentACK message a modal information dialog
- change some QObject::tr() to just tr()
- clarify the processPaymentRequest() error, when IsDust()
- small string change to prevent a tripple + usage with QString

bitcoingui: show main window (if hidden) on modal messages