GitLab

Merge branch '139-impl-finalbudget-order-agnostic-comparison' into 142-prevent-voting-during-finalization

CBudgetManager::UpdateProposal() now checks if the vote timestamp
is within 75% of estimated time before the superblock (2880 blocks
times 1 min in mainnet). If not - vote is rejected.

* CBudgetManager::SubmitProposalVote() is added
* SubmitProposalVote is used in rpc-masternode-budget.cpp to submit
  new votes for proposals. UpdateProposal is used now only to add
  votes received through the network
* SubmitProposalVote and UpdateProposal got draft implementation
  of prvention of voting during budget finalization
* Some unit tests added

* Protocol version is updated to 70053
* Minimum peer protocol version is decided in MinPeerProtoVersion()
  function
* SPORK_16_DISCONNECT_OLD_NODES added to allow smooth network update
  if mandatory update is necessary

Masternodes will always vote for finalized budgets regardless of
budgetvotemode setting

Proposals are ordered in a Budget by the amount of votes they get.
However, when the budget is finalized only the set of payments is
taken into account, not the order of elements of the set. When the
proposals are paid, they are sorted by amount from largest to
smallest. If the amounts are equal - the one with a smaller hash
is paid first.

* Tests for CFinalizedBudget::GetBudgetPaymentByBlock
* New test for CFinalizedBudget::IsTransactionValid
* Minor refactoring

* CFinalizedBudget::IsTransactionValid()

* Tests for CFinalizedBudget::AutoCheck
* Tests for CFinalizedBudget::GetHash

Added warning message to wait until ecryption is done

See merge request crown/crown-core!100