GitLab

prevent compiler redefinition warnings

- I observed a massive amount of redefinition warnings after #3071, which
  are silenced by this patch
- uses the same style as we do in other places, where we define _WIN32_WINNT

Remove include of windows.h from allocators.h

Rework pull-tester scripts, disable blockchain tester

Not working on the pull-tester machine, 'make cov' hangs there.

Re-organize the pull-tester scripts a bit.

And disables running the blockchain tester, it is not working properly
on the pull-tester machine for reasons I cannot explain (fails to start).

make fCommandLine a local variable in AppInit()

Create an allocators.cpp, and move all of the #ifdef WIN32
code and the #include of windows.h into it.

Two motives for this cleanup:
1. I'm getting a weird error in windows.h in my smartfee branch.
2. allocators.h is included (indirectly) just about everywhere, so
this should speed up Windows compiles quite a lot.

Bitcoin-Qt: ensure Qt icon is shown with Qt >= 5.0

add missing Boost Thread join_all() call during shutdown

style-police: fixed badly readable code in ProcessMessage()

- I introduced the problem and fixed it with better readable code

- fixes #3037 by adding missing join_all() call and brings bitcoind
  shutdown code in line with Bitcoin-Qt shutdown code
- added a comment for the if (!fRet) case

Bitcoin-Qt: prevent stuck/unusable debug window on exit

Hurricane Electric uses block 2001:470::, not 2011:470::

- when closing the client with an open debug window, that window could
  become stuck/unsuable (it was still shown wherea the main window was
  hidden already)
- fix this by hiding the debug window, when quitting the the client

special case DoS value == 0

- prevents unneeded log messages, which could make users think something
  bad was happening

[wallet] Consider generated coins mature at COINBASE_MATURITY+1

Update contrib/debian: proper desktop category and update changelog

Bitcoin-Qt: add missing change from branch Qt_misc

fix #3049 by changing comment for CNetAddr::IsRFC4193()

rename bitcoin-res.rc to bitcoind-res.rc

Fix and improve release-process.md

release-process.md has the deps being built after qt. However, the descriptors for qt call for the deps file.

This commit adds a step, which is to git checkout the version to be
built. This ensures that the gitian-descriptors for said version will be
the correct ones. In addition, it updates the links for several
dependencies, where the previously existing links were dead.

log start and end of Shutdown()

- helps recognizing that the resource file belongs to bitcoind.exe

- could be helpful when debugging shutdown related problems

a pre-req for no-wallet support.

notably RPC.