GitLab

As block index entries have a flag for marking invalid blocks, the
'best invalid work' information can be derived from there. In addition,
remove the global from main.h

9eb4ab66 transactionview: make exportClicked() use message() (Philip Kaufmann)
868d3ee5 transactionview: add message() signal (Philip Kaufmann)

71ba4670 [Qt] sendcoinsdialog: convert QMessageBox usage to message() (Philip Kaufmann)

re-work -debug switch handling

- add new processSendCoinsReturn() function, which parses the
  status of WalletModel::SendCoinsReturn and generates a pair consisting
  of a message and message flags
- result is we only need one emit message() call
- this change ensures that the GUI is shown for warnings/errors in
  sendcoinsdialog, because of message() taking care of that for modal
  messages
- changes 2 warning message into error messages and removed "Error:"
  in front of the actual error message string

- use message() for displaying success or failure of export
- rework the strings to be more detailed / informative
- additional small cleanups

- allow to use message() in transactionview by connecting to the
  message() signal in WalletView

[Qt] walletview: make backupWallet() use GUIUtil::getSaveFileName()

- re-work -debug help message text
- make -debug log every debugging information again (even all categories)
- remove unneeded fDebug checks in front of LogPrint()/qDebug(), as that
  check is done in LogPrintf() when category is != NULL (true for all
  LogPrint() calls
- remove fDebug ONLY in code which is NOT performance-critical
- harmonize addrman category name
- deprecate -debugnet usage, should be used via -debug=net and remove the
  corresponding global

fix wrong memcmp() usage in CKey::operator==

-fuzzmessagestest=N : randomly corrupt 1-of-N sent messages

Interaction cleanups between main and wallet

Remove redundant insert method in serialize

I needed this to test the new "reject" p2p message, but it should be generally
useful for fuzz-testing network message handling code.

Changed CDataStream::GetAndClear() to use the most obvious
get get and clear instead of a tricky swap().

Added a unit test for CDataStream insert/erase/GetAndClear.

Note: GetAndClear() is not performance critical, it is used only
by the send-a-message-to-the-network code. Bug was not noticed
before now because the send-a-message code never erased from the
stream.

- add a check for CKey::size() of a and b (size can be 0 or 32)
- change the fixed value in memcmp() to use a.size() instead
- fixes #3090

Generalize the remove-outputs check for fully-prunable transactions.

Instead of explicitly testing for the presence of any output, and
dealing with this case specially, just interpret it as an empty
CCoins.

The case previously caught using the HaveCoins check, is now handled
by the generic outs != outsBlock test.

Use a GridLayout instead of a FormLayout. This makes the alignment
of the labels consistent between the tabs.

Missed RPC port

Re-enable Jenkins and run more tests on Jenkins than pull-tester gets

Re-enable BitcoindComparisonTool on pull-tester

- this allows removal of several Qt headers and makes use of a
  standardized function in GUIUtil
- adds selected path to the UI output

GUIUtil: make getSaveFileName() use native OS path separators

qt: english language update

[Qt] additional small fixes for #3099 (new receive flow)

qt: clean up signal handling in walletframe/walletview

Use proper signals everywhere.
Removes the need to store a pointer to the BitcoinGUI object in
the walletview.
Also removes the interdependence between setWalletModel / setBitcoinGUI.

 * Use the latest version, with limited memory usage, and path to
   on-disk db (try mouting qa/tmp on a tmpfs)\
 * enable -debug=net
 * re-enable BitcoindComparisonTool in pull-tester

- remove 2 unneeded windowTitle attributes, which bloat our translations
- cleanup some unneeded .cpp/.h includes and class usages
- use a more generic string for clearing sendcoinsdialog and
  requestpaymentdialog
- edit 2 strings in BitcoinGUI and replace "edit" with "show" as this
  seems more clear in the context where it is used

This seems to cause problems on recent clang, and looks totally
redundant and unused.

The const_iterator version is identical to the vector::const_iterator
one (which is a typedef thereof). Marking it private (instead of
removing) compiles fine, so this version is effectively unused even.