- remove some missplaced ;
- ensure end of a namespace is clearly visible
- use same formatting when using namespace

75c82d49 Move coins.cpp and keystore.cpp to libbitcoin_common (Wladimir J. van der Laan)
84ce18ca Remove unnecessary dependencies for bitcoin-cli (Wladimir J. van der Laan)
14f888ca Move network-time related functions to timedata.cpp/h (Wladimir J. van der Laan)

Prepare for introduction of `bitcoin-tx` tool.

This commit removes all the unnecessary dependencies (key, core,
netbase, sync, ...) from bitcoin-cli.

To do this it shards the chain parameters into BaseParams, which
contains just the RPC port and data directory (as used by utils and
bitcoin-cli) and Params, with the rest.

The network time-offset-mangement functions from util.cpp are moved to
timedata.(cpp|h). This breaks the dependency of util on netbase.

fd704c7b move pow constants to chainparams (jtimon)
df852d2b Refactor proof of work related functions out of main (jtimon)

6dc90ed8 replace 3 separate calls to WSAGetLastError() with 1 (Philip Kaufmann)

e9f2460c Add dependencies for Mac OSX gitian builds (Drak)

b79f59b9 Update .gitignore (Drak)

e3aedbae Consistent lettering (Whit J)

Removing old file ignores so they show up in `git status`

5fbb4c9b [Qt] fix links in about window not opening (Philip Kaufmann)

1c750dbd remove -tor compatibility code (only allow -onion) (Philip Kaufmann)

0655fac0 miner: indentation fixes, remove for (;;) (Philip Kaufmann)

77cbd462 Let -zapwallettxes recover transaction meta data (Cozz Lovan)

- closes #4402

- exit, if -tor option is found and give error to user

f3967bcc build: fix build weirdness after 54372482. (Cory Fields)

bitcoin-config.h moved, but the old file is likely to still exist when
reconfiguring or switching branches. This would've caused files to not rebuild
correctly, and other strange problems.

Make the path explicit so that the old one cannot be found.

Core libs use config/bitcoin-config.h.

Libs (like crypto) which don't want access to bitcoin's headers continue
to use -Iconfig and #include bitcoin-config.h.

qa/rpc_tests: Wait for handshake to complete in connect_nodes

This avoids a race condition in which the connection was
made but the version handshake is not completed yet. In that
case transactions won't be broadcasted to a peer yet, and
the nodes will wait forever for their mempools to sync.

3f9a0199 added list/get received by address/ account tests (Alon Muroch)

b3c912d9 [Qt] Change Coin control labels and tooltips because of non-rounding fees (Cozz Lovan)

It is outdated information. If we ever resurrect gitian-downloader it
can be brought back from history and updated.

fa126eff Avoid undefined behavior using CFlatData in CScript serialization (Wladimir J. van der Laan)

`&vch[vch.size()]` and even `&vch[0]` on vectors can cause assertion
errors with VC in debug mode. This is the problem mentioned in #4239.
The deeper problem with this is that we rely on undefined behavior.

- Add `begin_ptr` and `end_ptr` functions that get the beginning and end
  pointer of vector in a reliable way that copes with empty vectors and
  doesn't reference outside the vector
(see https://stackoverflow.com/questions/1339470/how-to-get-the-address-of-the-stdvector-buffer-start-most-elegantly/1339767#1339767).
- Add a convenience constructor to CFlatData that wraps a vector.

I added `begin_ptr` and `end_ptr` as separate functions as I imagine
they will be useful in more places.

3dc1464f add missing vhListenSocket.clear(); to CNetCleanup() (Philip Kaufmann)
2831a03b remove unused CNode::Cleanup() (Philip Kaufmann)

040c2d3f Fix formatting (Drak)

b612bde5 remove unneded class CNodeCombinedStats; from rpcconsole.cpp (Philip Kaufmann)

- also 2 small style fixes

d38da59b Code simplifications after CTransaction::GetHash() caching (Pieter Wuille)
4949004d Add CMutableTransaction and make CTransaction immutable. (Pieter Wuille)

806fd19e Allocate receive buffers in on the fly (Pieter Wuille)

- change a for (;;) into while (true), as we nowhere else use the first
- init nNonceFound to 0
- fix indentation in BitcoinMiner try/catch block